Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: backwards compatible dashboards with cortex_request_duration_seconds as native histogram #7377

Closed
wants to merge 16 commits into from

Conversation

krajorama
Copy link
Contributor

@krajorama krajorama commented Feb 14, 2024

What this PR does

Update our dashboards to use the new cortex_request_duration_seconds native histogram as input , but allow using the classic histogram version as well.

Which issue(s) this PR fixes or relates to

Fixes #7154
Depends on grafana/jsonnet-libs#1136

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Recording rules, alerts, dashboards.

Signed-off-by: György Krajcsovits <[email protected]>
Same as for QPS panel.

Signed-off-by: György Krajcsovits <[email protected]>
Otherwise yaxes is changed from "reqps" to "short" in the generated
dashboard.

Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
@krajorama krajorama requested a review from a team as a code owner February 14, 2024 08:35
@krajorama krajorama marked this pull request as draft February 14, 2024 08:35
@krajorama
Copy link
Contributor Author

We've analyzed the different options and this was one of the worst in terms of complexity and possibility to automate to conversion for other applications/customers. Closing as failed.

@krajorama krajorama closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using native histogram version of latency metrics in Mimir
1 participant